Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only display oss included projects/environments when install is oss #8896

Merged
merged 9 commits into from
Dec 19, 2024
Merged

feat: only display oss included projects/environments when install is oss #8896

merged 9 commits into from
Dec 19, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Nov 29, 2024

Trying again, now with a tested function for resolvingIsOss.

Still want to test this on a pro instance in sandbox before we deploy this to our customers to avoid what happened Friday.

@chriswk chriswk self-assigned this Nov 29, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 0:09am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 0:09am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

gastonfournier
gastonfournier reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a feature flag to release it in a more controlled way and validate in prod?

@chriswk
Copy link
Member Author

chriswk commented Dec 3, 2024

Will update this to not filter the client-features query. Let's not mess with SDK results

@chriswk
Copy link
Member Author

chriswk commented Dec 3, 2024

Can we add a feature flag to release it in a more controlled way and validate in prod?

Yes. If you can turn the entire thing off with a feature flag though it defeats the purpose of the limitation, which is why I did not add a feature flag for this initially.

@gastonfournier
Copy link
Contributor

Can we add a feature flag to release it in a more controlled way and validate in prod?

Yes. If you can turn the entire thing off with a feature flag though it defeats the purpose of the limitation, which is why I did not add a feature flag for this initially.

makes sense

@github-actions GitHub Actions
Copy link
Contributor

@chriswk, core features have been modified in this pull request. Please review carefully!

gastonfournier
gastonfournier approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll test carefully before releasing

gastonfournier
gastonfournier approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk marked this pull request as ready for review December 19, 2024 13:33
@chriswk chriswk merged commit 66907bf into main Dec 19, 2024
8 checks passed
@chriswk chriswk deleted the task/ossCheck branch December 19, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonfournier gastonfournier gastonfournier approved these changes

@ivarconr ivarconr Awaiting requested review from ivarconr

@sighphyre sighphyre Awaiting requested review from sighphyre

@FredrikOseberg FredrikOseberg Awaiting requested review from FredrikOseberg

Assignees

@chriswk chriswk

Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriswk @gastonfournier